Bindings for ImGuiColorTextEdit 🙂 #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks very promising! I'll defenetly review the PR, but probably closer to the weekend. For now you can see that CI fails on the checkstyle. Would you likely to fix it? (Checkstyle can be run locally with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This began as a personal addition since I needed this for my hobby game engine, but I decided that it is (just maybe) "good enough" to be merged upstream, and I saw someone asking for it so there you are.
Since I'm rather inexperienced in JNI and C++ this code may not be up to the highest standard... but it works, on all three platforms!
I've tried to be as close as possible to SpaiR's codestyle, but of course suggestions are always very welcome.
Most of the things are implemented, some functions needed to be "abstracted" a little bit since ImGuiColorTextEdit uses a lot of C++ standard library features.
Hope it's useful!
And an image, because why not.
