Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed window rendering on resize and white background on start up. #62

Merged
merged 3 commits into from
Jun 24, 2021

Conversation

Marco012
Copy link
Contributor

With this PR, the window is able to render and receive events while resizing, instead of leaving a black area. This also opens the window with the background color 'colorBg' instead of a white flicker.

Copy link
Owner

@SpaiR SpaiR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Please, take a look at CI results. Your code violates some of checkstyle rules, which need to be addressed.

imgui-app/src/main/java/imgui/app/Window.java Outdated Show resolved Hide resolved
imgui-app/src/main/java/imgui/app/Window.java Show resolved Hide resolved
@SpaiR SpaiR added the feat New feature or request label Jun 23, 2021
Copy link
Owner

@SpaiR SpaiR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@SpaiR SpaiR merged commit 34e282e into SpaiR:master Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants