-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
datamodel: add load
as an allowed variable
#806
Conversation
Add `load` as an allowed variable. Previously the datamodel only supported `net_load` as a variable and therefore made no distinction between (gross) load vs net load. One of the key differences is that load is generally defined as a non-negative measure of energy demand, while net load is the signed measured of energy demand import (positive values) vs export (negative values). This is a subtle but important difference, and supporting both variables (`load` and `net_load`) in the datamodel will enable better defined functionality for users. For example, when validating load data, negative values should be treated as erroroneous. But negative values net load data should be treated as valid.
Note: the way everything is coded in the API and Dashboard, the addition of the |
Forgot to mention: based on discussions among the current project team, we settled on using the nomenclature of "load" and "net load", rather than "gross load" and "net load", where "load" is a non-negative measure of energy demand while "net load" is a signed measure to differentiate between import vs export of energy (e.g., import energy to meet demand vs export excess solar generation once the local demand is met). This is due to a combination of factors, including higher prevalence of "load" compared to "gross load" (or similarly, "true demand") and simplicity of naming. While there are valid arguments for other choices, the choice of "load" as the name seems to be the best choice at this time for all those involved in the Arbiter (contributors/maintainers, forecast providers, and forecast consumers). |
I've been able to replicate using the local dashboard. Changes are straightforward and simple. No pytest issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple. Test and repeated in dashboard.
net_load
), so for now this PR does not add new tests.docs/source/api.rst
for API changes. NOTE: no API changesdocs/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).Add
load
as an allowed variable. Previously the datamodel only supportednet_load
as a variable and therefore made no distinction between (gross) load vs net load. One of the key differences is that load is generally defined as a non-negative measure of energy demand, while net load is the signed measured of energy demand import (positive values) vs export (negative values). This is a subtle but important difference, and supporting both variables (load
andnet_load
) in the datamodel will enable better defined functionality for users. For example, when validating load data, negative values should be treated as erroroneous. But negative values net load data should be treated as valid.