Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncAPi Importer - warn if message is used by multiple channels #121

Open
195858 opened this issue Oct 5, 2023 · 1 comment
Open

AsyncAPi Importer - warn if message is used by multiple channels #121

195858 opened this issue Oct 5, 2023 · 1 comment

Comments

@195858
Copy link
Contributor

195858 commented Oct 5, 2023

Describe the bug
Importer uses message form AsyncAPI to create an Event in EP.

If a message is referenced in multiple channels the import fails as it attempts to attach different topics attached to the same event.

To Reproduce
Steps to reproduce the behavior:
Import the Async API attached
Observer the error

A clear and concise description of what happens.

Expected behavior
A clear and concise description of what you expected to happen.

Log files
If applicable, add log file(s) to help troubleshoot the problem.

Additional context
Add any other context about the problem here.
ERPO2CAPI.yaml.zip

@TamimiGitHub
Copy link
Collaborator

TamimiGitHub commented Oct 5, 2023

Explicitly defining the event name in the spec file will bypass this error

channels:
  sales/{object}/notification/{version}/{erp_id}/{sales_organization}/{distribution_channel}/{division}:
    x-ep-event-name: "Object"
    description: 'Event responsible for providing information about ERP orders/invocies/etc. changes that can be consumed by client system to properly inform end-user.'
    parameters:
      $ref: '#/components/parameters'
    publish:
      message:
        $ref: '#/components/messages/Notification'
  erp/{erp_id}/notification/{version}/{object}/{sales_organization}/{distribution_channel}/{division}:
    x-ep-event-name: "ERP ID"
    description: 'Event responsible for providing information about ERP orders/invocies/etc. changes that can be consumed by client system to properly inform end-user.'
    parameters:
      $ref: '#/components/parameters'
    subscribe:
      message:
        $ref: '#/components/messages/Notification'

However I do agree that this should be handled more gracefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants