SyntaxError: Identifier 'global' has already been declared

[johnny-mcfadden-dailypay]

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch socketcluster-client@19.1.2 for the project I'm working on ("expo": "51.0.17" + "react-native": "0.74.2" being the main upgrade drivers that resulted in this issue).

On web, we are running into an issue with global already declared, causing our web bundling to fail.

Here is the diff that solved my problem that I hoped to shared with others.

diff --git a/node_modules/socketcluster-client/lib/ws-browser.js b/node_modules/socketcluster-client/lib/ws-browser.js
index 32e279c..1614e0d 100644
--- a/node_modules/socketcluster-client/lib/ws-browser.js
+++ b/node_modules/socketcluster-client/lib/ws-browser.js
@@ -1,11 +1,11 @@
-let global;
+let globalScope;
 if (typeof WorkerGlobalScope !== 'undefined') {
-  global = self;
+  globalScope = self;
 } else {
-  global = typeof window !== 'undefined' && window || (function() { return this; })();
+  globalScope = typeof window !== 'undefined' && window || (function() { return this; })();
 }
 
-const WebSocket = global.WebSocket || global.MozWebSocket;
+const WebSocket = globalScope.WebSocket || globalScope.MozWebSocket;
 
 /**
  * WebSocket constructor.

This issue body was partially generated by patch-package.

[jondubois]

@johnny-mcfadden-dailypay Thanks for this report. This suggestion has been implemented and published as socketcluster-client@19.2.2.