Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node6 does not support syntax of trailing comma #147

Labels

Comments

@chenhebing
Copy link

Hi, when use this plugin, I get the following error.

/node_modules/add-asset-html-webpack-plugin/lib/index.js:121
      );
      ^

SyntaxError: Unexpected token )

My node version is v6.16.0, and the engines node of this plugin is greater or equal to 6. But node6 does not support trailing comma syntax.

I upgrade node to v8.x.x, this plugin work well.

@SimenB
Copy link
Owner

SimenB commented Jan 27, 2019

Gah, I'm dumb. I run prettier on the output from babel, which adds the trailing commas... Will fix, sorry!

@SimenB SimenB closed this as completed in 1e6fb04 Jan 27, 2019
@SimenB
Copy link
Owner

SimenB commented Jan 27, 2019

🎉 This issue has been resolved in version 3.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chenhebing
Copy link
Author

🎉 This issue has been resolved in version 3.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Gah, I'm dumb. I run prettier on the output from babel, which adds the trailing commas... Will fix, sorry!

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment