Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically replacing of ' with " #419

Closed
nice2know opened this issue Jul 17, 2024 · 3 comments
Closed

Automatically replacing of ' with " #419

nice2know opened this issue Jul 17, 2024 · 3 comments
Labels
area:theme-check Bug Something isn't working

Comments

@nice2know
Copy link

Sometimes when I enter ' it got be replaced with ". In my case it distroys the Code.
It all happens in Line 5. There are ' needed, but when I save my file, it got replaced.

Source

<div
    class="product__section-images product__section-image--{{ thumbnail_position }} carousel-container js-product-gallery span-6 md-span-12 sm-span-12 auto{% if section.settings.details_beside %} details-beside {% endif %}"
    data-product-gallery
    data-product-single-media-group
    data-gallery-config="{{ product_gallery_config }}"
    data-aos="fade"
  >
    ...
</div>
@nice2know nice2know changed the title Automatic replacing of ' width " Automatic replacing of ' with " Jul 17, 2024
@nice2know nice2know changed the title Automatic replacing of ' with " Automatically replacing of ' with " Jul 17, 2024
@lucyxiang lucyxiang added Bug Something isn't working theme-check area:theme-check and removed theme-check labels Jul 18, 2024
@lukeh-shopify
Copy link
Contributor

Hey @nice2know, sorry that you are experiencing this!

In the prettier plugin for liquid, there is a singleQuote configuration option. I'm wondering if changing those settings will prevent your code from being destroyed. Would you be able to try that out and let me know how it goes?

Thanks

@lukeh-shopify
Copy link
Contributor

👋🏻 Hey @nice2know, because there hasn’t been activity in the last couple of weeks we’ll be closing this issue. However if you’re still experiencing the same problem, please reopen the issue and share the outstanding context we’ve requested. Thanks!

@nice2know
Copy link
Author

Thanks a lot, worked for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:theme-check Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants