Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme check failing on comments in JSON file....added by Shopify #45

Open
jlbruno opened this issue Jun 18, 2024 · 1 comment
Open

Theme check failing on comments in JSON file....added by Shopify #45

jlbruno opened this issue Jun 18, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jlbruno
Copy link

jlbruno commented Jun 18, 2024

Describe the bug
Theme check is returning an error on a JSON file because it has a comment block in it...that looks like it was added by Shopify.

image

Expected
Theme check shouldn't error on anything that's being added by Shopify

Actual
Theme check throws an error on comments in JSON file.

Stack trace

Debugging information

  • Github action using shopify/theme-check-action@v2
  • Also fails on local terminal using shopify CLI version 3.62.0
@jlbruno jlbruno added the bug Something isn't working label Jun 18, 2024
@lukeh-shopify lukeh-shopify transferred this issue from Shopify/theme-check Jul 12, 2024
@lukeh-shopify
Copy link

lukeh-shopify commented Jul 12, 2024

Hi @jlbruno, I've moved this to the appropriate repository. I believe we have released changes that should have resolved your issue. Are you able to confirm this is still a problem? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants