You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
We had UnusedSnippet on with autofix and files that were actually being used were being deleted. We could turn off autofix, but it would then still have false positives and report an error. They use the {% render 'snippet' %} syntax.
Expected
UnusedSnippet should not report on snippets that are actually used.
Actual
UnusedSnippet does report on snippets that are used.
Debugging information
Mac Apple M2, but also in Github Actions
Version: 1.15.0
The text was updated successfully, but these errors were encountered:
Hi @saiichihashimoto, thanks for the report. Are you able to switch to the more maintained non Ruby version (shopify/theme-check-action@v2) of the Github Action and confirm this is still an issue? The ruby version is now deprecated.
Nothing in this repo mentions that this is deprecated, correct me if I'm wrong. Also, are you saying that we've replaced the local cli with a github action only? Very confusing where I'm supposed to install this from or file this issue for it to just get closed and not moved to the correct repo... 😭
Describe the bug
We had UnusedSnippet on with autofix and files that were actually being used were being deleted. We could turn off autofix, but it would then still have false positives and report an error. They use the
{% render 'snippet' %}
syntax.Expected
UnusedSnippet should not report on snippets that are actually used.
Actual
UnusedSnippet does report on snippets that are used.
Debugging information
The text was updated successfully, but these errors were encountered: