Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TranslationKeyExists or MatchingSchemaTranslations or MatchingTranslations with --auto-correct flag replaces contents of every json file with null #735

Closed
bmandl opened this issue Jun 12, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@bmandl
Copy link

bmandl commented Jun 12, 2023

Describe the bug
If theme check for TranslationKeyExists or MatchingSchemaTranslations or MatchingTranslations with --auto-correct flag is run, contents of every json file except default locale json files get replaced with null.

Expected
All json files, except locale json files should stay intact.

Actual
All json files contents gets replaced with null

Debugging information

  • OS [wsl 2 Ubuntu 20.04]
  • Version (1.15.0)
@bmandl bmandl added the bug Something isn't working label Jun 12, 2023
@lukeh-shopify
Copy link

👋🏻 Hi @bmandl! Thanks for reporting this. Unfortunately the Ruby version of theme check has been deprecated for some time. Would you be able to confirm you are still having issues when using our maintained version of theme check? This is done using either the latest version of the Shopify CLI, or via the Shopify Liquid Visual Studio Code extension.

If you are still having issues, please raise an issue over in the CLI or theme tools repositories. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants