Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Intelligent code completion] Support collection retrieved via its name #404

Open
Poitrin opened this issue Dec 12, 2022 · 0 comments
Open
Labels
area:theme-check enhancement New feature or request

Comments

@Poitrin
Copy link

Poitrin commented Dec 12, 2022

Created by
Shopify/theme-liquid-docs#18

Describe the bug
Intelligent Code Completion does not support collection retrieved via its name.
Therefore, collections.first.products is supported, but collections['sale-potions'].products isn't.

Expected
In the example …

{% for x in collections['sale-potions'].products %}
    {{- x.█

x should be treated as a product, so that suggestions for product (available, collections, compare_at_price, …) are displayed at the cursor's position.

Actual
Wrong suggestions

x seems to be treated as a collection, so that suggestions for collection are displayed.

@Poitrin Poitrin added the Bug Something isn't working label Dec 12, 2022
@lukeh-shopify lukeh-shopify transferred this issue from Shopify/theme-check Jul 12, 2024
@charlespwd charlespwd added enhancement New feature or request and removed Bug Something isn't working labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:theme-check enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants