Skip to content
This repository has been archived by the owner on Jul 27, 2024. It is now read-only.

Throw warning/errors when an custom element isn't closed with the proper tag #640

Closed
ludoboludo opened this issue Sep 21, 2022 · 1 comment

Comments

@ludoboludo
Copy link

Is your feature request related to a problem? Please describe.

We had an instance in Dawn where theme check didn't pick up on an custom element being closed with the wrong tag.

Here is the scenario:

<slideshow-component>
  ...
</slider-component>

Describe the solution you'd like

I wonder if there could be a check around custom elements to make sure the closing tag is using the same name ?

Describe alternatives you've considered

No alternatives, just making sure we review our code for those kind of mistakes.

Additional context

PR that fixed this on Dawn: Shopify/dawn#1981

@lukeh-shopify
Copy link
Contributor

Seems to be fixed on the latest theme check

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants