Skip to content
This repository has been archived by the owner on Jul 27, 2024. It is now read-only.

Ensure <head> and <body> tags are closed in themes #584

Closed
catlee opened this issue May 27, 2022 · 1 comment
Closed

Ensure <head> and <body> tags are closed in themes #584

catlee opened this issue May 27, 2022 · 1 comment
Labels
e:3 Effort: 3 enhancement New feature or request linter Check related issues

Comments

@catlee
Copy link
Contributor

catlee commented May 27, 2022

We've noticed that sometimes app embeds fail to inject into a theme because the theme is missing proper </head> and/or </body> tags.

Can we add a check for layout files that these tags are properly closed?
@charlespwd charlespwd added the bug Something isn't working label May 31, 2022
@charlespwd charlespwd added enhancement New feature or request e:3 Effort: 3 linter Check related issues and removed bug Something isn't working labels Jul 26, 2022
@lukeh-shopify
Copy link
Contributor

Looks to be resolved in the latest theme check

image image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
e:3 Effort: 3 enhancement New feature or request linter Check related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@catlee @charlespwd @lukeh-shopify