Skip to content

Commit

Permalink
Centralize Ruby Version to .ruby-version (#1830)
Browse files Browse the repository at this point in the history
* Remove TargetRubyVersion in rubocop config

As it reads from required_ruby_version in the gemspec

* Remove ruby version definitions in GH Actions workflows

As it reads from .ruby-version
  • Loading branch information
jenshenny authored Mar 26, 2024
1 parent 81c81d3 commit b6dd39a
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 6 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ jobs:
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: "3.3"
bundler-cache: true

- name: Check if documentation is up to date
Expand Down Expand Up @@ -86,8 +85,6 @@ jobs:
# We need some Ruby installed for the environment activation tests
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: "3.3.0"

- name: Download shadowenv
if: matrix.os == 'ubuntu-latest' || matrix.os == 'macos-latest'
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/lsp_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ jobs:
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: "3.2"
bundler-cache: true

- name: Run ruby-lsp-check
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/version_bump.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ jobs:
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: 3.3.0
bundler-cache: true
cache-version: 1

Expand Down
1 change: 0 additions & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ require:
AllCops:
NewCops: disable
SuggestExtensions: false
TargetRubyVersion: 3.0
Include:
- "sorbet/rbi/shims/**/*.rbi"
Exclude:
Expand Down

0 comments on commit b6dd39a

Please sign in to comment.