Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add delegate notification API #477

Closed
wants to merge 1 commit into from
Closed

Add delegate notification API #477

wants to merge 1 commit into from

Conversation

KaanOzkan
Copy link
Contributor

I went with kwargs for all, it differs from send_notification this way but I think it's clearer than positional args.

@KaanOzkan KaanOzkan requested a review from a team as a code owner October 4, 2024 15:30
@KaanOzkan KaanOzkan mentioned this pull request Oct 4, 2024
Merged
andyw8
andyw8 approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@andyw8 andyw8 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can skip adding a test for this.

@KaanOzkan
Copy link
Contributor Author

I think we can skip adding a test for this.

Thanks, I did test manually.

@vinistock
Copy link
Member

I added this PR #474, which includes a bit more. Can we move forward with that one?

@KaanOzkan KaanOzkan closed this Oct 4, 2024
@KaanOzkan KaanOzkan deleted the ko/delegate branch October 4, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyw8 andyw8 andyw8 approved these changes

@alexcrocha alexcrocha Awaiting requested review from alexcrocha alexcrocha is a code owner automatically assigned from Shopify/ruby-dx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KaanOzkan @vinistock @andyw8