Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Hydrogen broken in Cloudflare production #968

Closed
jplhomer opened this issue Mar 21, 2022 · 0 comments · Fixed by #975
Closed

[BUG] Hydrogen broken in Cloudflare production #968

jplhomer opened this issue Mar 21, 2022 · 0 comments · Fixed by #975
Assignees
Labels
bug Something isn't working

Comments

@jplhomer
Copy link
Contributor

jplhomer commented Mar 21, 2022

Describe the bug
https://template-default.hydrogen-devs.workers.dev/

The logs we get in Cloudflare don't give us anything, so you have to debug it locally using wrangler dev to see more detailed errors.

tl;dr here is that cloudflare will cancel the request if it finds that you are not planning to return something. i've seen this happen before when promises are involved (spoiler: we have a ton of promises involved).

It seems likely that a change in #758 caused this, though I remember @frandiox had it working in CF before 🤔 Maybe it was some other recent change.

Red herrings to avoid: The Cloudflare Deployment GH Action is currently failing, but it's due to an update in wrangler clearing out stale files. The actual deploy itself is fine.

To Reproduce
I started a branch here: https://github.com/Shopify/hydrogen/tree/jl-wip-cf-debugging

You'll want to run yarn and then inside the template, run wrangler dev (install wrangler first if you don't have it).

  • Hydrogen version: current v1.x-2022-07 branch
@jplhomer jplhomer added the bug Something isn't working label Mar 21, 2022
@frandiox frandiox self-assigned this Mar 22, 2022
@frandiox frandiox mentioned this issue Mar 22, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants