Support RuboCop 1.38 #288
Merged
Support RuboCop 1.38 #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version of RuboCop needs registry and config attributes to be set on the ProcessedSource object. These attributes do not exist in earlier versions of RuboCop.
|
Perhaps another Gemfile needs to be added in |
Comment on lines
+139
to
+143
| if ::RuboCop::Version::STRING.to_f >= 1.38 | ||
| registry = RuboCop::Cop::Registry.global | ||
| source.registry = registry | ||
| source.config = @rubocop_config | ||
| end |
There was a problem hiding this comment.
Can we do the check on feature rather than version?
Suggested change
| if ::RuboCop::Version::STRING.to_f >= 1.38 | |
| registry = RuboCop::Cop::Registry.global | |
| source.registry = registry | |
| source.config = @rubocop_config | |
| end | |
| source.registry = RuboCop::Cop::Registry.global if source.respond_to?(:registry=) | |
| source.config = @rubocop_config if source.respond_to?(:config=) |
There was a problem hiding this comment.
Well, the two things go together so it doesn't seem sensible to have two conditions.
Also, there is already a version check in that file: https://github.com/Shopify/erb-lint/blob/9b7dec10f51cd5e505347aded25d4d7e1aec94c4/lib/erb_lint/linters/rubocop.rb#L39, so it seems consistent to handle this the same way.
Finally, if ever in the distant future erb-lint supports only RuboCop 1.38 and above, it will be easier to see that the condition can be removed.
|
Thanks, @etiennebarrie! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #286.