Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CACHE_DIRECTORY from .erb-lint-cache to .erb_lint_cache? #379

Closed
joshuapinter opened this issue Sep 23, 2024 · 2 comments · Fixed by #380
Closed

Rename CACHE_DIRECTORY from .erb-lint-cache to .erb_lint_cache? #379

joshuapinter opened this issue Sep 23, 2024 · 2 comments · Fixed by #380

Comments

@joshuapinter
Copy link
Contributor

I see you've standardized on using erb_lint instead of erb-lint or erblint - that's great and much appreciated.

Do we want to also rename the CACHE_DIRECTORY from .erb-lint-cache to .erb_lint_cache?
@joshuapinter joshuapinter changed the title Rename .erb-lint-cache to .erb_lint_cache? Rename CACHE_DIRECTORY from .erb-lint-cache to .erb_lint_cache? Sep 23, 2024
@etiennebarrie
Copy link
Member

Yes I think that was an oversight. We'd welcome your contribution. Thanks!

joshuapinter added a commit to cntral/erb_lint that referenced this issue Sep 24, 2024
@joshuapinter
Rename CACHE_DIRECTORY to .erb_lint_cache.
af5f18e 
From `.erb-lint-cache`.

This is to align with the general renaming and standardization from `erb-lint` and `erblint` to `erb_lint`.

Fixes Shopify#379.
@joshuapinter joshuapinter mentioned this issue Sep 24, 2024
Merged
@joshuapinter
Copy link
Contributor Author

You got it. See #380.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename CACHE_DIRECTORY to .erb_lint_cache. cntral/erb_lint
2 participants
@etiennebarrie @joshuapinter