Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First working version of the Hanasaki implementation
Some issues/thoughts:
the part where the inflow and demand values are saved in the memory is not yet included (let me know if I should give it a try)
the monthly mean inflow parameters (
RPARAM_in(segIndex)%H06_I_Jan, RPARAM_in(segIndex)%H06_I_Feb, etc
) are zero in the module (while they have values onnetwork_topology_Dickson.nc
and this file is correctly specified in theHanasaki_lake.control
). I didn't investigate why (yet) but just added hardcoded values for the time being to test the code.the release coefficient
E_release
, needs to be communicated if it is determined at the start of the operational year: do we need to include this as a parameter? Also, a condition to determine the initial release coefficient still needs to be finetuned to only include the first months before the start of the first operational year.I still need to review my code and check the results themselves, as wel as do some testing with the other reservoir data before integration.