Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined issue #2249

Closed
Puja-Sharma opened this issue Mar 8, 2021 · 1 comment
Closed

undefined issue #2249

Puja-Sharma opened this issue Mar 8, 2021 · 1 comment

Comments

@Puja-Sharma
Copy link
Contributor

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch xlsx@0.16.9 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/xlsx/.gradle/6.7.1/executionHistory/executionHistory.bin b/node_modules/xlsx/.gradle/6.7.1/executionHistory/executionHistory.bin
new file mode 100644
index 0000000..f67bf4f
Binary files /dev/null and b/node_modules/xlsx/.gradle/6.7.1/executionHistory/executionHistory.bin differ
diff --git a/node_modules/xlsx/.gradle/6.7.1/executionHistory/executionHistory.lock b/node_modules/xlsx/.gradle/6.7.1/executionHistory/executionHistory.lock
new file mode 100644
index 0000000..267e56a
Binary files /dev/null and b/node_modules/xlsx/.gradle/6.7.1/executionHistory/executionHistory.lock differ
diff --git a/node_modules/xlsx/.gradle/6.7.1/fileChanges/last-build.bin b/node_modules/xlsx/.gradle/6.7.1/fileChanges/last-build.bin
new file mode 100644
index 0000000..f76dd23
Binary files /dev/null and b/node_modules/xlsx/.gradle/6.7.1/fileChanges/last-build.bin differ
diff --git a/node_modules/xlsx/.gradle/6.7.1/fileHashes/fileHashes.lock b/node_modules/xlsx/.gradle/6.7.1/fileHashes/fileHashes.lock
new file mode 100644
index 0000000..1a91a8d
Binary files /dev/null and b/node_modules/xlsx/.gradle/6.7.1/fileHashes/fileHashes.lock differ
diff --git a/node_modules/xlsx/.gradle/6.7.1/gc.properties b/node_modules/xlsx/.gradle/6.7.1/gc.properties
new file mode 100644
index 0000000..e69de29
diff --git a/node_modules/xlsx/.gradle/buildOutputCleanup/buildOutputCleanup.lock b/node_modules/xlsx/.gradle/buildOutputCleanup/buildOutputCleanup.lock
new file mode 100644
index 0000000..0466dd1
Binary files /dev/null and b/node_modules/xlsx/.gradle/buildOutputCleanup/buildOutputCleanup.lock differ
diff --git a/node_modules/xlsx/.gradle/buildOutputCleanup/cache.properties b/node_modules/xlsx/.gradle/buildOutputCleanup/cache.properties
new file mode 100644
index 0000000..72a74bf
--- /dev/null
+++ b/node_modules/xlsx/.gradle/buildOutputCleanup/cache.properties
@@ -0,0 +1,2 @@
+#Mon Mar 08 14:19:52 IST 2021
+gradle.version=6.7.1
diff --git a/node_modules/xlsx/.gradle/checksums/checksums.lock b/node_modules/xlsx/.gradle/checksums/checksums.lock
new file mode 100644
index 0000000..6a95834
Binary files /dev/null and b/node_modules/xlsx/.gradle/checksums/checksums.lock differ
diff --git a/node_modules/xlsx/.gradle/configuration-cache/gc.properties b/node_modules/xlsx/.gradle/configuration-cache/gc.properties
new file mode 100644
index 0000000..e69de29
diff --git a/node_modules/xlsx/.gradle/vcs-1/gc.properties b/node_modules/xlsx/.gradle/vcs-1/gc.properties
new file mode 100644
index 0000000..e69de29
diff --git a/node_modules/xlsx/xlsx.js b/node_modules/xlsx/xlsx.js
index 8b0e3d3..bec835d 100644
--- a/node_modules/xlsx/xlsx.js
+++ b/node_modules/xlsx/xlsx.js
@@ -11489,9 +11489,13 @@ ixti = f[1][1]; r = f[1][2];
 					if(supbooks[bookidx] && supbooks[bookidx][nameidx]) o += supbooks[bookidx][nameidx].Name;
 					else if(supbooks[0] && supbooks[0][nameidx]) o += supbooks[0][nameidx].Name;
 					else {
-						var ixtidata = get_ixti_raw(supbooks, bookidx, opts).split(";;");
-						if(ixtidata[nameidx - 1]) o = ixtidata[nameidx - 1]; // TODO: confirm this is correct
-						else o += "SH33TJSERRX";
+						let ixtidata;
+						if (get_ixti_raw(supbooks, bookidx, opts) != undefined)
+						{
+							ixtidata = get_ixti_raw(supbooks, bookidx, opts).split(";;");
+							if(ixtidata[nameidx - 1]) o = ixtidata[nameidx - 1]; // TODO: confirm this is correct
+							else o += "SH33TJSERRX";
+						}						
 					}
 					stack.push(o);
 					break;

This issue body was partially generated by patch-package.

@reviewher
Copy link
Contributor

If you can share an example, it would be very helpful.

In the meanwhile, af47faa is slightly different but has the same effect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants