Skip to content
This repository has been archived by the owner on Apr 5, 2022. It is now read-only.

changed all uses of SECRET -> JWT_SECRET #61

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

joelazwar
Copy link
Contributor

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's add a bit more info to the README, since this key has to work for Supabase as well (might as well talk about that, and link to any docs about what the key should look like). Your jest config implies it has to be 32 chars wide? You should mention that in the README.

@joelazwar we're going to have to do a release to get this in Telescope, see #38, which @AmasiaNalbandian wrote (btw, that should be in Telescope, or we'll lose it).

After the release, @rclee91, @JiaHua-Zou and I have found you need to do pnpm install in Telescope to have it pick up the new version and update the lock file (i.e., after npm shows the new version).

@menghif menghif merged commit 1e6f149 into DevelopingSpace:master Feb 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants