This repository has been archived by the owner on Apr 5, 2022. It is now read-only.
Fix Dependencies #25
Merged
Fix Dependencies #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/Seneca-CDOT/satellite/blob/b1d93348abd09e03d4509fda8fef9545c99d288a/README.md?plain=1#L19-L32 |
|
Correct, that stuff is unrelated to the APM bits. |
humphd
approved these changes
Jan 20, 2022
| // Pretty debug logging | ||
| let logger = pino({ | ||
| prettyPrint: {}, | ||
| prettifier: require('pino-colada'), |
There was a problem hiding this comment.
In a follow-up, I'd like to fix how we do this. pino-collada is great for debugging, but it's not what we should use in production. Maybe you can work on that next?
There was a problem hiding this comment.
Yes, will do, since I'm also working with pino in #2499. I will fix there
* Remove elastic-apm-node
* Remove @elastic/ecs-pino-format
* Update Jest (To fix deprecated dependencies)
Kevan-Y
force-pushed
the
issues/issue-2678
branch
from
a9a6812
to
2e42afe
Compare
humphd
approved these changes
Jan 20, 2022
chrispinkney
approved these changes
Jan 20, 2022
|
@Kevan-Y go ahead and merge this when you're ready. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2678
Description
Test