Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): Bump github.com/jarcoal/httpmock from 1.0.8 to 1.3.1 in /scheduler #5223

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 24, 2024

Bumps github.com/jarcoal/httpmock from 1.0.8 to 1.3.1.

Release notes

Sourced from github.com/jarcoal/httpmock's releases.

v1.3.1

Fix:

v1.3.0

New features:

Miscellaneous:

  • documentation now uses new go1.19 doc features;
  • go minimal version required is now 1.13;
  • CI tests using go1.20 & golangci-lint v1.51.0.

v1.2.0

New features:

Fixes:

  • url.RawPath is used instead of url.Path when checking path alone for consistency with full URL check, which is always unescaped. Let 2 registered responders:

    1. GET http://z.tld/foo%2fbar
    2. GET /foo%2fbar

    Before this release:

    • GET http://z.tld/foo%2fbar is caught by 1
    • GET http://unknown.tld/foo%2fbar is not caught as the tested path is /foo/bar instead of /foo%2fbar

    From this release:

    • GET http://z.tld/foo%2fbar is caught by 1
    • GET http://unknown.tld/foo%2fbar is caught by 2
  • save of old clients transports is now protected from concurrent writes (@​roboslone).

Miscellaneous:

  • now use go-testdeep to simplify tests (saves >500 test lines);
  • go minimal version required is now 1.9;
  • CI tests using go1.18 & golangci-lint v1.45.0;
  • signatures (and so documentation) now use any type instead of interface{}, as appeared in go 1.18 (in a compatible manner with go<1.18).

Enjoy!

v1.1.0

New features:

... (truncated)

Commits
  • 8b32cd6 fix: BodyContainsBytes & BodyContainsString used with And/Or
  • 497153d ci: test against go 1.21 & use golangci-lint 1.54.1
  • 070d3c8 ci: switch to install-go v3.4
  • 1ddb9fa refactor: make golangci-lint v1.52.2 happy
  • 507a05e ci: add workflow_dispatch as event trigger
  • e977d51 Merge pull request #139 from jarcoal/go120
  • df3afac ci: test with go1.20
  • 837f061 Merge pull request #138 from jarcoal/headers
  • d4ab20c feat: add Responder.{SetContentLength,HeaderAdd,HeaderSet} methods
  • db50b76 perf(matchers): simplify http.NoBody case
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/jarcoal/httpmock](https://github.com/jarcoal/httpmock) from 1.0.8 to 1.3.1.
- [Release notes](https://github.com/jarcoal/httpmock/releases)
- [Commits](jarcoal/httpmock@v1.0.8...v1.3.1)

---
updated-dependencies:
- dependency-name: github.com/jarcoal/httpmock
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from sakoush as a code owner January 24, 2024 15:50
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 24, 2024
@dependabot dependabot bot requested a review from lc525 as a code owner January 24, 2024 15:50
@dependabot dependabot bot added the v2 label Jan 24, 2024
@seldondev
Copy link
Collaborator

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@sakoush sakoush changed the title Bump github.com/jarcoal/httpmock from 1.0.8 to 1.3.1 in /scheduler fix(deps): Bump github.com/jarcoal/httpmock from 1.0.8 to 1.3.1 in /scheduler Jan 29, 2024
@sakoush sakoush merged commit f7d1fdd into v2 Jan 29, 2024
3 of 5 checks passed
@dependabot dependabot bot deleted the dependabot/go_modules/scheduler/v2/github.com/jarcoal/httpmock-1.3.1 branch January 29, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file needs-ok-to-test v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants