Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable default logging for Kafka in Ansible Playbooks #4990

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

vtaskow
Copy link
Contributor

@vtaskow vtaskow commented Jul 6, 2023

What this PR does / why we need it:
When running Seldon via Ansible playbooks, Kafka logs everything, which makes it difficult to inspect the logs of seldon-pipelinegateway when using pipelines.

@vtaskow vtaskow changed the title fix: Disable default logging for Kafka fix: Disable default logging for Kafka in Ansible Playbooks Jul 6, 2023
Copy link
Contributor

@agrski agrski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than removing the config from the Helm chart, I'd instead suggest adding a Helm variable to control it. Note that this is not config for Kafka itself, but rather for our components about Kafka.

Being able to modify log verbosity is useful for both developers and end users, so I'd prefer not to see utility removed!

@ukclivecox
Copy link
Contributor

Rather than removing the config from the Helm chart, I'd instead suggest adding a Helm variable to control it. Note that this is not config for Kafka itself, but rather for our components about Kafka.

Being able to modify log verbosity is useful for both developers and end users, so I'd prefer not to see utility removed!

There is a helm value for it. This is the ansible use of it which should be configurable via allowing helm values or for now removed so its not hard wired.

@agrski
Copy link
Contributor

agrski commented Jul 6, 2023

There is a helm value for it. This is the ansible use of it which should be configurable via allowing helm values or for now removed so its not hard wired.

Ah yes, I forgot the context. I'd still be in favour of this being configurable easily. I don't mind if that's even just leaving it as info level so it's still obvious that setting is there, without having to dig around to find it.

@ukclivecox ukclivecox added the v2 label Jul 7, 2023
@ukclivecox ukclivecox merged commit aaf2fdc into SeldonIO:v2 Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants