Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix test logic, get rid of k6 warning #4945

Merged
merged 1 commit into from
Jun 27, 2023
Merged

fix: Fix test logic, get rid of k6 warning #4945

merged 1 commit into from
Jun 27, 2023

Conversation

apaleyes
Copy link
Contributor

What this PR does / why we need it:
Two things:

  1. Gets rid of "The headers property is deprecated, replace it with the metadata property, please." warning from k6
  2. Fixes logic in "infer_constant_vu.js" scenario so that we don't skip iterations when using only one protocol for test

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
tested by running locally

@apaleyes apaleyes requested a review from sakoush June 27, 2023 10:33
sakoush
sakoush approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@sakoush sakoush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely! thanks for sorting it out.

@apaleyes apaleyes changed the title Fix test logic, get rid of k6 warning fix: Fix test logic, get rid of k6 warning Jun 27, 2023
@apaleyes apaleyes merged commit c885611 into v2 Jun 27, 2023
@apaleyes apaleyes deleted the load-test-update branch June 27, 2023 10:38
@sakoush sakoush added the v2 label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sakoush sakoush sakoush approved these changes

Assignees
No one assigned
Labels
v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apaleyes @sakoush