Make rclone config_secrets configurable in values.yaml

[ghuntexscientia]

What this PR does / why we need it:

The docs detail adding rclone secrets which can be used to connect to different storage providers (https://deploy.seldon.io/en/v2.0/contents/operations/storage-initializers/index.html?highlight=storage%20initializers). However, this is currently hard-coded in the helm chart with config_secrets: ["seldon-rclone-gs-public"] so it is only possible to edit using kubectl. This means GitOps users (e.g. ArgoCD) don't have an easy way to set up alternative secrets.

This change moves the default config_secrets to values.yaml so it can be edited easily.

Special notes for your reviewer:

As per https://seldonio.atlassian.net/servicedesk/customer/portal/1/CSM-606. Original PR in SeldonIO/helm-charts#38.

[seldondev]

Hi @ghuntexscientia. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

[RafalSkolasinski]

Hey @ghuntexscientia - thanks for opening the PR here. We do need to however add it via Kustomize patch as our Helm charts are generated from kustomize. Probably it'd need to a new patch under https://github.com/SeldonIO/seldon-core/tree/v2/k8s/kustomize/helm-components as I don't seem to see one for agent there yet

[ghuntexscientia]

Hi @RafalSkolasinski - I've added a new patch as you suggest, but as far as I can tell the agent.yaml isn't included in those resources. It points to ../componentsNoConfig which in turn has - ../../../scheduler/k8s/defaultNoConfig as a base. However scheduler/k8s/defaultNoConfig/kustomization.yaml doesn't include scheduler/k8s/config/agent.yaml.

[ghuntexscientia]

Hi @RafalSkolasinski, as far as I can tell, the following files are not created/managed by kustomize:

• k8s/helm-charts/seldon-core-v2-setup/templates/agent.yaml
• k8s/helm-charts/seldon-core-v2-setup/templates/rclone-gs-public.yaml
• k8s/helm-charts/seldon-core-v2-setup/templates/tracing.yaml

You can reproduce this by modifying or deleting one, and running make create-helm-charts.

If this is true, am I clear to modify agent.yaml directly as in my original commit?

[ukclivecox]

If we merge the clusterwide install these will be changeable in the new SeldonRuntime, SeldonConfig custom resources.

[ukclivecox]

@ghuntexscientia Thanks!