Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add CI workflow ensuring PR titles conform to Conventional Commit format #4891

Merged

Conversation

agrski
Copy link
Contributor

@agrski agrski commented Jun 6, 2023

What this PR does / why we need it:
This PR adds a check for PR titles to ensure that they are compatible with the Conventional Commit format. This imposes minimal burden to contributors: they need to specify the type of change, whether or not it is a breaking change, and optionally its scope.

This has a couple of benefits, both for human users and automation. For maintainers, it is easier to quickly grok the scope and impact of changes due to the additional context. Using tools like grep, it is also easy to filter for particular types of changes. We could consider using the CC format in release notes in the future, such that changes are automatically grouped into sections, e.g. new features, bug fixes, and breaking changes.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
The PR check can be seen working on this PR. Initially it will fail as I have deliberately not met the CC format for the title. After changing this, the check should pass.

@agrski agrski requested a review from ukclivecox June 6, 2023 22:43
@agrski agrski self-assigned this Jun 6, 2023
@agrski agrski changed the title Add CI workflow for linting PR titles ci: Add CI workflow for linting PR titles Jun 6, 2023
@agrski agrski changed the title ci: Add CI workflow for linting PR titles ci: Add CI workflow ensuring PR titles conform to Conventional Commit format Jun 6, 2023
@agrski agrski marked this pull request as ready for review June 7, 2023 09:19
@agrski agrski requested a review from sakoush June 7, 2023 09:19
@sakoush sakoush added the v2 label Jun 7, 2023
Copy link
Member

@sakoush sakoush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agrski agrski merged commit 700eb2c into SeldonIO:v2 Jun 7, 2023
@agrski agrski deleted the add-ci-for-conventional-commit-pr-title-checks branch June 7, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants