Fix deletion of model in cases of ModeFailed
and ScheduleFailed
with server disconnects
#4882
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes issues related to the user wanting to delete a model (using
kubectl
) in the following cases:ModelFailed
models in the cases where the server replica disconnected. In this case we are going to force a reschedule to reconcile the model state.SechduleFailed
models that transitioned from some other state (e.g. the model was loaded on a server then the server got disconnected and we could not now schedule the model). In this case the issue was that the model state had a server associated with it that caused issues. This PR clears this state.These issues were all related to the finalizer.
Which issue(s) this PR fixes:
Special notes for your reviewer: