Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update envoy and go-control-plane and fix deprecations #4872

Merged
merged 1 commit into from
May 30, 2023
Merged

Update envoy and go-control-plane and fix deprecations #4872

merged 1 commit into from
May 30, 2023

Conversation

ukclivecox
Copy link
Contributor

@ukclivecox ukclivecox commented May 29, 2023

This PR updates envoy and go-control plane and fixes configuration (and issues) that were present in reverted PR #4867

  • Updates envoy to v1.26.1
    • Fix listener filter creation by specifying the type as dscussed here and here due to a change from 1.22
  • Updates go-control-plane to 0.11.1 (just released)
  • fixes deprecations in resources
    • Use DefaultSourceCode rather than inlineCode for LUA script
    • Use StringMatcher rather than older methods in header matching
    • Removes TotalWeight as its no longer needed in weighted clusters

Note: 0.11.0 of go-control-plane causes issues in which the delta XDS updates seem to go into a loop showing

time="2023-05-29T16:08:49Z" level=debug msg="node: test-id, sending delta response for typeURL type.googleapis.com/envoy.config.route.v3.RouteConfiguration with resources: [listener_0] removed resources: [] with wildcard: false"
time="2023-05-29T16:08:49Z" level=debug msg="node: test-id, sending delta response for typeURL type.googleapis.com/envoy.config.route.v3.RouteConfiguration with resources: [listener_1] removed resources: [] with wildcard: false"
time="2023-05-29T16:08:49Z" level=debug msg="node: test-id, sending delta response for typeURL type.googleapis.com/envoy.config.route.v3.RouteConfiguration with resources: [listener_0] removed resources: [] with wildcard: false"

This seems to be fixed in 0.11.1 (released today!) but its unclear why from release notes and slack disucssion with Alex Holmes (go-control-plane lead).

Envoy tested via running through notebooks locally and on k8s.

@ukclivecox ukclivecox requested a review from sakoush May 29, 2023 17:10
@ukclivecox ukclivecox added the v2 label May 29, 2023
Copy link
Member

@sakoush sakoush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, could you mention the tests you have done to make sure it works?

@ukclivecox ukclivecox merged commit 1e7585c into SeldonIO:v2 May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants