Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a macOS m1 specific build target for seldon client #4838

Merged
merged 2 commits into from
May 24, 2023

Conversation

rajatvig
Copy link

What this PR does / why we need it:

Ship an ARM Seldon CLI binary that can be used for macOS. The build tags are documented here. Adding the -tags dynamic builds the binary on a macOS M1 and works assuming librdkafka has been installed. brew can install it.

Which issue(s) this PR fixes:
None

Special notes for your reviewer:

Unsure how the release for the binary happens and where to add any documentation for it.

@seldondev
Copy link
Collaborator

Hi @rajatvig. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@agrski agrski added the v2 label May 11, 2023
@sakoush
Copy link
Member

sakoush commented May 15, 2023

Many thanks for the contribution @rajatvig
This looks fine. Could you also add a note in the docs to reflect this feature: e.g. in docs/source/contents/getting-started/cli.md and docs/source/contents/cli/index.md?

Signed-off-by: Rajat Vig <rvig@etsy.com>
@rajatvig
Copy link
Author

@sakoush Have updated the docs.

@ukclivecox ukclivecox merged commit 85cf41c into SeldonIO:v2 May 24, 2023
@rajatvig rajatvig deleted the AddArmBinTarget branch May 25, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants