-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mermaid diagrams to pipeline docs page #4837
Add mermaid diagrams to pipeline docs page #4837
Conversation
These are great - they provide an extra layer of understanding which helps |
Super! I have two minor points:
|
Thanks, updated.
I'm in two minds about this. In general, there are 3 types of joins that can happen in a pipeline:
Now, ideally I would not have done the That being said, I'll put up the version with |
I've added explicit output join step to the two relevant examples (conditional and trigger join) as I think it adds more clarity. This PR is ready now @cliveseldon Postponed or abandoned:
|
What this PR does / why we need it:
Add basic visualizations of example pipelines in the docs.
Special notes for your reviewer:
mermaid
as it's code based and easier to update and manage than external assets like images, produced with another tool. The trade-off is that the layout and styling options are more limited.:caption:
and:align:
directives, which may be due to the docs themeSee relevant docs page here: https://seldon--4837.org.readthedocs.build/projects/seldon-core/en/4837/contents/pipelines/index.html