feat(models): Add model status message for k8s resource status #4834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is dependent on whether or not the load can be retried.
agrski
commented
May 9, 2023
| ) { | ||
| modelStatus := schedulerAPI.ModelStatus_ModelFailed | ||
| if canRetry { | ||
| modelStatus = schedulerAPI.ModelStatus_ModelProgressing |
There was a problem hiding this comment.
ℹ️ The equivalent pipeline code simply says the pipeline failed if there was any issue requesting it to be loaded. Which behaviour do we want -- indicate failure early, or be optimistic as transient glitches can happen?
There was a problem hiding this comment.
I've updated the pipeline status to not indicate failure from retryable errors: 8f16995
agrski
force-pushed
the
add-model-status-message-for-k8s-resource-status
branch
from
558b0a6
to
8f16995
Compare
ukclivecox
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a
messagefield for model statuses to indicate, at a high level, why a model is (not) ready. At present, models can only be ready or not ready, and may have areasondescribing the underlying cause of that status. That reason is fine for humans, but is verbose and is not suitable for automated systems to parse easily.This PR also updates the pipeline status fields to share the same semantics are for models:
There are also a number of formatting changes to break long lines (>120 characters) and introduce some whitespace for logical grouping/separation.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer: