Fix python grpc api build #4791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ukclivecox
commented
Apr 10, 2023
ukclivecox
commented
- Creates python folder
- Creates grpc python bindindings
- Uses the python grpc-protoc needed for python rather than the usual protoc binary
agrski
reviewed
May 3, 2023
There was a problem hiding this comment.
I've tested this with:
cd apis
python3 -m venv venv
source venv/bin/activate
pip install grpcio-tools
make build-v2-pythonI've confirmed this generates sensible-looking outputs.
💭 I've made a couple of suggestions for the Makefile.
❓ Separately, elsewhere we've added the generated clients into git. Should we do that here as well?
agrski
reviewed
May 3, 2023
| mkdir -p python | ||
| python -m grpc_tools.protoc \ | ||
| $(PROTOC_IMPORT_PATH) \ | ||
| $(PROTOC_PYTHON_OPTIONS) \ | ||
| --grpc_python_out=./python \ | ||
| --pyi_out=./python \ |
There was a problem hiding this comment.
🔧 Same here about duplicated info!
agrski
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.