Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dataflow): Add missing filter for requests without input tensors #4779

Merged
merged 1 commit into from
Apr 6, 2023
Merged

feat(dataflow): Add missing filter for requests without input tensors #4779

merged 1 commit into from
Apr 6, 2023

Conversation

ukclivecox
Copy link
Contributor

Missing filter for joining pipelines when there are no tensor matches.

@ukclivecox ukclivecox added the v2 label Apr 4, 2023
@ukclivecox ukclivecox requested a review from agrski April 4, 2023 08:46
agrski
agrski approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@agrski agrski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot!

❓ Do we need an equivalent for outputs/responses?

@agrski agrski changed the title Add missing filter Add missing filter for requests without input tensors Apr 6, 2023
@agrski agrski changed the title Add missing filter for requests without input tensors feat(dataflow): Add missing filter for requests without input tensors Apr 6, 2023
@agrski agrski merged commit c5d2733 into SeldonIO:v2 Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrski agrski agrski approved these changes

Assignees
No one assigned
Labels
v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ukclivecox @agrski