Fix model artifact versions #4774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
agrski
reviewed
Mar 31, 2023
samples/k8s-multi-version.md
Outdated
| ``` | ||
|
|
||
| ```bash | ||
| kubectl create -f ./models/multi-version-1.yaml -n ${NAMESPACE} |
There was a problem hiding this comment.
💭 Probably worth using apply here as we expect to update this later; I realise this is generated from the notebook
agrski
reviewed
Mar 31, 2023
| @@ -54,6 +55,7 @@ local-examples.md | |||
| k8s-examples.md | |||
| huggingface.md | |||
| model-zoo.md | |||
| multi-version.md | |||
There was a problem hiding this comment.
❓ Has this file been added?
agrski
reviewed
Mar 31, 2023
agrski
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix artifact version is not passed to scheduler from Model yaml.
Fixes: #4770