-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recreate examples for mlserver 1.2.4 #4719
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left some comments.
@@ -0,0 +1,18 @@ | |||
VERSION := $(shell grep seldonio/mlserver ../../../scheduler/Makefile | cut -d':' -f2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we move this under samples/scripts/
for consistency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe in a future PR - as need to discuss how these more complex examples are trained together
@@ -20,7 +20,7 @@ SCHEDULER_IMG ?= ${DOCKERHUB_USERNAME}/seldon-scheduler:${CUSTOM_IMAGE_TAG} | |||
TRITON_IMG ?= nvcr.io/nvidia/tritonserver:22.11-py3 | |||
GPU_ENABLED ?= 0 | |||
|
|||
KIND_NAME=ansible | |||
KIND_NAME=seldon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is that really intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes Rafal changed the defaults for ansible
No description provided.