Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix golang version in security tests #4716

Merged
merged 6 commits into from
Mar 9, 2023
Merged

Fix golang version in security tests #4716

merged 6 commits into from
Mar 9, 2023

Conversation

sakoush
Copy link
Member

@sakoush sakoush commented Mar 9, 2023 •
edited by RafalSkolasinski
Loading

What this PR does / why we need it:

Fix snyk golang image version to 1.19 in security tests. I have also disabled buildvcs

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@sakoush sakoush added the v2 label Mar 9, 2023
RafalSkolasinski
RafalSkolasinski approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

agrski
agrski approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@agrski agrski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinning to the version of Go we use makes sense, as does adding the -buildvcs=false flag

@sakoush sakoush merged commit ab171a1 into SeldonIO:v2 Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafalSkolasinski RafalSkolasinski RafalSkolasinski approved these changes

@agrski agrski agrski approved these changes

Assignees
No one assigned
Labels
v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sakoush @RafalSkolasinski @agrski