Increase idle connection of REST proxy to timeout to 30 minutes #4713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrski
approved these changes
Mar 7, 2023
|
How hard would it be to make this configurable? |
ukclivecox
approved these changes
Mar 7, 2023
not hard but it is probably a set of constants that we need to make configurable not just this one. So will leave to a future PR perhaps, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Increase default idle timeout of REST proxy to 30 minutes. This is the connection between agent and model server. Otherwise for a single inference requests that takes more than the default threshold (previously 1 minutes) the connection drops.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: