Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model server controlplane interface #4706

Merged
merged 19 commits into from
Mar 8, 2023
Merged

Add model server controlplane interface #4706

merged 19 commits into from
Mar 8, 2023

Conversation

sakoush
Copy link
Member

@sakoush sakoush commented Mar 6, 2023

What this PR does / why we need it:

This PR adds an interface for control plane with a specific implementation of the Open Inference Protocol (v2). This allows then other plugable implementations for the control plane for backends that do not support the v2 protocol (e.g. TorchServe).

This PR also adds a couple of refactors:

  • Introduce internal packages for testing utils
  • Remove Rest support for current v2 client, we only use Grpc in production
  • Add Rest v2 client as a client for testing purposes only

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@sakoush sakoush requested a review from ukclivecox March 6, 2023 17:55
@sakoush sakoush added the v2 label Mar 6, 2023
@sakoush sakoush changed the title Add v2 controlplane interface Add model server controlplane interface Mar 6, 2023
@ukclivecox
Copy link
Contributor

Looks good - please run notebook tests locally and on k8s

@sakoush
Copy link
Member Author

sakoush commented Mar 8, 2023

Looks good - please run notebook tests locally and on k8s

done.

@sakoush sakoush merged commit 5f73d8a into SeldonIO:v2 Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants