Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update e2e tests and add Combiner to python wrappers #343

Merged
merged 6 commits into from
Dec 15, 2018
Merged

Update e2e tests and add Combiner to python wrappers #343

merged 6 commits into from
Dec 15, 2018

Conversation

ukclivecox
Copy link
Contributor

@ukclivecox ukclivecox commented Dec 15, 2018

  • Add Combiner handling to python wrappers
  • Adds a Combiner example
  • Updates e2e tests to include s2i built images of all types
    • model, router, transformer, combiner

Fixes #296

@ukclivecox ukclivecox merged commit 80b7761 into SeldonIO:master Dec 15, 2018
@ukclivecox ukclivecox deleted the combiner branch February 14, 2020 11:40
agrski added a commit that referenced this pull request Dec 2, 2022
* Move operational metrics docs under general metrics page

* Capitalise proper nouns & acronyms/initialisms

* Use one sentence per line for operational metrics

* Add empty docs page for usage metrics

* Add list of metrics to docs from Hodometer README

* Add intro & privacy sections to Hodometer docs

* Add link to table of metrics in Hodometer docs

* Add section on metrics levels in Hodometer docs

* Change list of metrics level to table

* Use metrics levels name corresponding to allowed values in table

* Add table of Hodometer env vars to usage metrics docs

* Add sed script adding Helm templating for Hodometer deployment

* Split sed script over multiple lines for legibility

* Simplify sed script for maintainability

Inserting before and appending after a multi-line string is simpler than replacing parts of it.
The output is now shared across branches, regardless of whether or not the deployment is for Hodometer.
A further (arguable) benefit is that YAML document markers are per-document, rather than potentially
creating an empty document; this would be peculiar for anyone viewing Helm template output.

* Refactor Helm template paths to Make vars for concision & consistency

* Add enabled field for Hodometer in Helm values template

* Add Helm templating for Hodometer installation toggle in Makefile

* Regenerate Helm charts

* Update sed script to apply to all resources with hodometer in the name

* Regenerate Helm charts

* Add Helm/k8s configuration section for Hodometer

* Add tab for Helm install of Hodometer for k8s

* Add tab for raw YAML install of Hodometer for k8s

* Shorten section heading for clarity in usage metrics docs

* Add sentence on configuring k8s raw YAML manifests in usage metrics docs

* Add docs section on Compose configuration for Hodometer

* Add section on performance & resource requirements of Hodometer

* Add section on using extra publish URLs with Hodometer

* Use monospace for Hodometer metric names in README table

* Add brief descriptions of op & usage metrics on metrics overview page

* Hide TOC on metrics page as links are given above

* Add architecture diagram for Hodometer

* Add architecture section to usage metrics docs

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a python wrapper for COMBINER components
1 participant