Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm-charts upgrade fails on ambassador #543

Closed
OrBarda opened this issue May 7, 2019 · 5 comments
Closed

helm-charts upgrade fails on ambassador #543

OrBarda opened this issue May 7, 2019 · 5 comments
Assignees

Comments

@OrBarda
Copy link

OrBarda commented May 7, 2019

When trying to upgrade the helm charts of Seldon-core to release 0.2.7, it shows a problem in the deployment which is related to the ambassador:
image (5)
Then when trying again to upgrade getting the following:
image (6)
And eventually what happens is that a new cluster-manager is up but the old one stay as well and for upgrading the ambassador a delete of the chart is needed which causes a problem in availability.

@ryandawsonuk
Copy link
Contributor

ryandawsonuk commented May 7, 2019

I think this is because we're now using the ambassador helm chart. helm/helm#1193 has been a helm issue for a while - an example of a similar failure with a chart resource (also a service account but can happen with other resources too) is cert-manager/cert-manager#677. The issue is reported as fixed but the fix is quite recent. Which helm version are you using?

@OrBarda
Copy link
Author

OrBarda commented May 9, 2019

we are using 2.12.3.

@ryandawsonuk
Copy link
Contributor

I think the next step is to see if we can recreate this with the latest version of helm. We can install an old version of seldon-core and then do a helm upgrade to the new version. I'll aim to do this soon.

@ryandawsonuk
Copy link
Contributor

Actually ambassador will soon be removed from the seldon-core main chart so anyone upgrading to that version will need to install ambassador separately or add it to their own wrapper chart. This issue will then no longer apply

@ukclivecox
Copy link
Contributor

Fix by new separation of operator from ingress.

agrski pushed a commit that referenced this issue Dec 2, 2022
…543)

* Fix initial and delete of Pipelines

* remove msg and make fatal initial envoy update error

* review updates

* review empty line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants