Skip to content

Commit

Permalink
Add more test cases for load_annotations..
Browse files Browse the repository at this point in the history
Also remove mock_open line, since it's forgotten.
  • Loading branch information
Che Vu Gia Hy committed Oct 11, 2019
1 parent 52752f0 commit 42181e7
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion python/tests/test_microservice.py
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,8 @@ def test_model_template_bad_params_type():
def test_load_annotations(mock_isfile):
from io import StringIO
read_data = [
('', {}),
('\n\n', {}),
('foo=bar', {'foo': 'bar'}),
('foo=bar\nx =y', {'foo': 'bar', 'x': 'y'}),
('foo=bar\nfoo=baz\n', {'foo': 'baz'}),
Expand All @@ -187,6 +189,5 @@ def test_load_annotations(mock_isfile):
('foo=\nfoo', {'foo': ''}),
]
for data, expected_annotation in read_data:
m = mock.mock_open(read_data=data)
with mock.patch('seldon_core.microservice.open', return_value=StringIO(data)):
assert microservice.load_annotations() == expected_annotation

0 comments on commit 42181e7

Please sign in to comment.