Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update twine requirement from <4.0.0,>3.2.0 to >3.2.0,<5.0.0 #511

Merged
merged 3 commits into from
Apr 27, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 19, 2022

Updates the requirements on twine to permit the latest version.

Release notes

Sourced from twine's releases.

4.0.0

https://pypi.org/project/twine/4.0.0/

Changelog

Changelog

Sourced from twine's changelog.

Twine 4.0.0 (2022-03-31)

Features ^^^^^^^^

  • Drop support for Python 3.6. ([#869](https://github.com/pypa/twine/issues/869) <https://github.com/pypa/twine/issues/869>_)
  • Use Rich to add color to upload output. ([#851](https://github.com/pypa/twine/issues/851) <https://github.com/pypa/twine/issues/851>_)
  • Use Rich to add color to check output. ([#874](https://github.com/pypa/twine/issues/874) <https://github.com/pypa/twine/issues/874>_)
  • Use Rich instead of tqdm for upload progress bar. ([#877](https://github.com/pypa/twine/issues/877) <https://github.com/pypa/twine/issues/877>_)

Bugfixes ^^^^^^^^

  • Remove Twine's dependencies from the User-Agent header when uploading. ([#871](https://github.com/pypa/twine/issues/871) <https://github.com/pypa/twine/issues/871>_)
  • Improve detection of disabled BLAKE2 hashing due to FIPS mode. ([#879](https://github.com/pypa/twine/issues/879) <https://github.com/pypa/twine/issues/879>_)
  • Restore warning for missing long_description. ([#887](https://github.com/pypa/twine/issues/887) <https://github.com/pypa/twine/issues/887>_)

Twine 3.8.0 (2022-02-02)

Features ^^^^^^^^

  • Add --verbose logging for querying keyring credentials. ([#849](https://github.com/pypa/twine/issues/849) <https://github.com/pypa/twine/issues/849>_)
  • Log all upload responses with --verbose. ([#859](https://github.com/pypa/twine/issues/859) <https://github.com/pypa/twine/issues/859>_)
  • Show more helpful error message for invalid metadata. ([#861](https://github.com/pypa/twine/issues/861) <https://github.com/pypa/twine/issues/861>_)

Bugfixes ^^^^^^^^

  • Require a recent version of urllib3. ([#858](https://github.com/pypa/twine/issues/858) <https://github.com/pypa/twine/issues/858>_)

Twine 3.7.1 (2021-12-07)

Improved Documentation ^^^^^^^^^^^^^^^^^^^^^^

  • Fix broken link to packaging tutorial. ([#844](https://github.com/pypa/twine/issues/844) <https://github.com/pypa/twine/issues/844>_)

Twine 3.7.0 (2021-12-01)

Features

... (truncated)

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Updates the requirements on [twine](https://github.com/pypa/twine) to permit the latest version.
- [Release notes](https://github.com/pypa/twine/releases)
- [Changelog](https://github.com/pypa/twine/blob/main/docs/changelog.rst)
- [Commits](pypa/twine@3.3.0rc1...4.0.0)

---
updated-dependencies:
- dependency-name: twine
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label May 19, 2022
Copy link
Contributor

@ascillitoe ascillitoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not merge.

twine>=4.x currently causes dependency conflicts, as it requires rich>=12.0.0 -> requires typing-extensions>=4.0.0 -> too high for spacy and thinc pulled in by alibi (in notebook tests). See #508 (comment). Should be reviewed later once spacy and thinc allow typing-extensions>=4.0.0.

@jklaise jklaise changed the title Update twine requirement from <4.0.0,>3.2.0 to >3.2.0,<5.0.0 [DO NOT MERGE] Update twine requirement from <4.0.0,>3.2.0 to >3.2.0,<5.0.0 May 19, 2022
@ascillitoe ascillitoe added the DO NOT MERGE Do not merge this PR label Aug 10, 2022
@ascillitoe ascillitoe changed the title [DO NOT MERGE] Update twine requirement from <4.0.0,>3.2.0 to >3.2.0,<5.0.0 Update twine requirement from <4.0.0,>3.2.0 to >3.2.0,<5.0.0 Aug 10, 2022
@ascillitoe
Copy link
Contributor

@dependabot rebase

@ascillitoe
Copy link
Contributor

@dependabot recreate

@codecov-commenter
Copy link

Codecov Report

Merging #511 (9cf8eb1) into master (83b5d2f) will decrease coverage by 0.16%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #511      +/-   ##
==========================================
- Coverage   80.16%   80.00%   -0.17%     
==========================================
  Files         133      133              
  Lines        9176     9135      -41     
==========================================
- Hits         7356     7308      -48     
- Misses       1820     1827       +7     
Flag Coverage Δ
macos-latest-3.10 ?
ubuntu-latest-3.10 ?
ubuntu-latest-3.7 ?
ubuntu-latest-3.8 ?
ubuntu-latest-3.9 80.00% <ø> (ø)
windows-latest-3.9 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
alibi_detect/saving/validators.py 76.92% <0.00%> (-13.47%) ⬇️
alibi_detect/utils/_types.py 95.23% <0.00%> (-4.77%) ⬇️
alibi_detect/utils/frameworks.py 88.88% <0.00%> (-3.71%) ⬇️
alibi_detect/utils/missing_optional_dependency.py 94.28% <0.00%> (-0.16%) ⬇️
alibi_detect/datasets.py 68.55% <0.00%> (-0.14%) ⬇️
alibi_detect/saving/schemas.py 98.69% <0.00%> (-0.09%) ⬇️
alibi_detect/utils/fetching/fetching.py 0.00% <0.00%> (ø)
alibi_detect/cd/base.py 91.19% <0.00%> (+0.21%) ⬆️
alibi_detect/od/vae.py 90.36% <0.00%> (+1.07%) ⬆️

Copy link
Contributor

@ascillitoe ascillitoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notebook and build CI are passing now that thinc and spacy support typing-extensions >= 4.0.

Can merge, pending alibi equivalent: SeldonIO/alibi#620

@ascillitoe ascillitoe removed the DO NOT MERGE Do not merge this PR label Jan 3, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 4, 2023

A newer version of twine exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@jklaise jklaise merged commit 7e6d9df into master Apr 27, 2023
@dependabot dependabot bot deleted the dependabot/pip/twine-gt-3.2.0-and-lt-5.0.0 branch April 27, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants