-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update twine requirement from <4.0.0,>3.2.0 to >3.2.0,<5.0.0 #511
Conversation
Updates the requirements on [twine](https://github.com/pypa/twine) to permit the latest version. - [Release notes](https://github.com/pypa/twine/releases) - [Changelog](https://github.com/pypa/twine/blob/main/docs/changelog.rst) - [Commits](pypa/twine@3.3.0rc1...4.0.0) --- updated-dependencies: - dependency-name: twine dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not merge.
twine>=4.x
currently causes dependency conflicts, as it requires rich>=12.0.0
-> requires typing-extensions>=4.0.0
-> too high for spacy and thinc pulled in by alibi (in notebook tests). See #508 (comment). Should be reviewed later once spacy
and thinc
allow typing-extensions>=4.0.0
.
@dependabot rebase |
@dependabot recreate |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #511 +/- ##
==========================================
- Coverage 80.16% 80.00% -0.17%
==========================================
Files 133 133
Lines 9176 9135 -41
==========================================
- Hits 7356 7308 -48
- Misses 1820 1827 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notebook and build CI are passing now that thinc
and spacy
support typing-extensions >= 4.0
.
Can merge, pending alibi
equivalent: SeldonIO/alibi#620
A newer version of twine exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Updates the requirements on twine to permit the latest version.
Release notes
Sourced from twine's releases.
Changelog
Sourced from twine's changelog.
... (truncated)
Commits
36695ab
Update changelog for 4.0.0 (#888)4931a2a
Make missinglong_description
check more flexible (#887)7cd0b23
Subclass StringIO for _WarningStream. (#886)aa7c047
Update sampleproject fixture (#885)a6dd69c
Adopt Python 3.7+ syntax (#882)a0ba32d
Drop support for Python 3.6 (#869)55652f0
Replace tqdm with Rich for progress bar (#877)c506b22
Filter unnecessary deps from User-Agent string (#871)a9e9cd6
Fix detection of FIPS mode for blake2b (#879)f69d4b7
Use Rich forprint()
output (#878)You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)