-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve handling of scalars in NetCDFTimeConverter.convert #46
Conversation
@spencerkclark Once #66 lands (hopefully), you'll need to rebase, then I'll review and merge 👍 |
@spencerkclark Time to rebase 👍 Then let's get this finally banked 😃 |
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
- Coverage 89.14% 89.08% -0.07%
==========================================
Files 1 1
Lines 175 174 -1
Branches 42 42
==========================================
- Hits 156 155 -1
Misses 13 13
Partials 6 6
Continue to review full report at Codecov.
|
I'll get to this, this evening 👍 Awesome! |
@spencerkclark Perfect, thanks 🍻 |
This provides a simple fix for #45.