Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI environment lockfiles #4194

Merged
merged 1 commit into from
Jun 16, 2021
Merged

Update CI environment lockfiles #4194

merged 1 commit into from
Jun 16, 2021

Conversation

github-actions[bot]
Copy link
Contributor

Lockfiles updated to the latest resolvable environment.

@trexfeathers
Copy link
Contributor

I'm not sure if this explains the current nc-time-axis errors, but I know for certain that the versions of nc-time-axis and cftime proposed here are incompatible. Although not recorded in the nc-time-axis requirements, v1.3 needs a minimum of cftime>=1.5 (currently Iris is pinned cftime<1.3). See SciTools/nc-time-axis#66 (comment).

@bjlittle
Copy link
Member

@trexfeathers Cool, I'll issue a patch for nc-time-axis 👍

@github-actions github-actions bot force-pushed the auto-update-lockfiles branch 2 times, most recently from 5076f4c to 0372446 Compare June 15, 2021 08:35
@trexfeathers
Copy link
Contributor

I can't work out why this is still resolving with nc-time-axis v1.3.1, given that recipe now requires cftime>=1.5. @bjlittle could it still be picking up a previous build, despite conda-forge/nc_time_axis-feedstock#23?

@trexfeathers
Copy link
Contributor

trexfeathers commented Jun 15, 2021

could it still be picking up a previous build, despite conda-forge/nc_time_axis-feedstock#23?

EDIT: resolution definitely is picking up an older build - nc-time-axis-1.3.1-pyhd8ed1ab_0. That probably makes sense, since it's the latest available version on conda-forge that doesn't have the minimum cftime pin. Can we follow the conda-forge broken package steps so that it's not an option for resolution?

@bjlittle
Copy link
Member

bjlittle commented Jun 16, 2021

@trexfeathers I think this is now fixed, see conda-forge/conda-forge-repodata-patches-feedstock#144, which retro-patches the appropriate nc-time-axis recipe metadata for 1.3.0, and 1.3.1 for good measure.

It's pretty cool... I didn't know that was possible, thanks @ocefpaf ❤️

@bjlittle
Copy link
Member

So when we unpin cftime in iris, we'll get the correct behaviour as far as nc-time-axis is concerned 👍

@bjlittle bjlittle self-requested a review June 16, 2021 06:30
@bjlittle bjlittle merged commit bc3b748 into master Jun 16, 2021
@QuLogic QuLogic deleted the auto-update-lockfiles branch June 16, 2021 08:19
@ocefpaf
Copy link
Member

ocefpaf commented Jun 16, 2021

It's pretty cool... I didn't know that was possible, thanks @ocefpaf

We were very "afraid" of repo patches due to possible reproducibility issues. In fact I was very against it. However, they are so useful that we got addicted to them and they are here to stay now 😄

@rcomer
Copy link
Member

rcomer commented Jun 18, 2021

I'm not sure if this explains the current nc-time-axis errors, but I know for certain that the versions of nc-time-axis and cftime proposed here are incompatible.

FWIW, I'm pretty sure it does: SciTools/nc-time-axis#71 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants