Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct build_r (currently SegFault for alpha=2) #59

Open
Philou31 opened this issue Dec 20, 2023 · 2 comments
Open

Correct build_r (currently SegFault for alpha=2) #59

Philou31 opened this issue Dec 20, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@Philou31
Copy link
Collaborator

No description provided.

@mknaranja mknaranja added the bug Something isn't working label Dec 20, 2023
@mknaranja
Copy link
Member

@julianlitz Did #60 actually solve this error or is this still persisting? Could you check in case you don't know?

@julianlitz
Copy link
Collaborator

julianlitz commented Aug 6, 2024

Yes it did resolve this error.
I implemented this fix in the refactored code as well and so far I didn't notice any issues.
But we should check for more r_jump values than the 4 cases to be sure.
Especially if r_jump is close to a boundary value.

However I find the value of r_jump \in (0, 1) to be very unintuitive for the user.
Since „r_“ appears in the variable name, one suspects it corresponds to a specific radius, but it rather seems to be a percentage of where to find the actual alpha_jump \in (0, Rmax).

I believe it would make more sense to pass in a alpha_jump radius instead of a percentage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Product backlog
Development

No branches or pull requests

3 participants