Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix on translating special characters #12

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix on translating special characters #12

wants to merge 5 commits into from

Conversation

jonata
Copy link

@jonata jonata commented Jan 29, 2021

Fixes #10 and other special characters.

Saravananslb
Saravananslb approved these changes Feb 2, 2021
View reviewed changes
Copy link
Owner

@Saravananslb Saravananslb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. We encourage contributor for this package.

@finia2NA finia2NA mentioned this pull request Mar 2, 2021
Closed
@finia2NA
Copy link

finia2NA commented Mar 2, 2021 •
edited

Very nice, this also fixes the issue that I had where translation would stop at a "。".

Considering that the changes fail testing only because the previous versions also failed, I think it would be good if the changes were merged into the main tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saravananslb Saravananslb Saravananslb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSONDecodeError: Expecting ',' delimiter during bulk translation
3 participants
@jonata @finia2NA @Saravananslb