-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate vi and i2ctool into builtin apps for tash #550
Conversation
d2c6a98
to
f72e503
Compare
apps/system/i2c/Makefile
Outdated
@@ -125,8 +127,17 @@ install: | |||
|
|||
endif | |||
|
|||
ifeq ($(CONFIG_SYSTEM_I2CTOOL),y) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only when CONFIG_BUILTIN_APPS is enabled.
let's change to ifeq (
apps/system/vi/Makefile
Outdated
@@ -128,8 +132,17 @@ install: | |||
|
|||
endif | |||
|
|||
ifeq ($(CONFIG_SYSTEM_VI),y) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
@tadziopazur Could you let us know why do you want to use it at TASH? VI is an imcomplete applicaion. |
Integrate vi into builtin apps
f72e503
to
f2f5cd6
Compare
Vi might be incomplete, but is useful for modifying short javascript files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is i2ctool detecting items ?
@@ -125,8 +127,17 @@ install: | |||
|
|||
endif | |||
|
|||
ifeq ($CONFIG_BUILTIN_APPS)$(CONFIG_SYSTEM_I2CTOOL),yy) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mistake fixed in:
#2439 (comment)
These tools come from apps/system.