Integrate vi and i2ctool into builtin apps for tash #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tadziopazur
force-pushed
the
builtin_apps
branch
from
d2c6a98
to
f72e503
Compare
jeongchanKim
reviewed
Sep 7, 2017
apps/system/i2c/Makefile
Outdated
| @@ -125,8 +127,17 @@ install: | |||
|
|
|||
| endif | |||
|
|
|||
| ifeq ($(CONFIG_SYSTEM_I2CTOOL),y) | |||
There was a problem hiding this comment.
This is only when CONFIG_BUILTIN_APPS is enabled.
let's change to ifeq (
apps/system/vi/Makefile
Outdated
| @@ -128,8 +132,17 @@ install: | |||
|
|
|||
| endif | |||
|
|
|||
| ifeq ($(CONFIG_SYSTEM_VI),y) | |||
|
@tadziopazur Could you let us know why do you want to use it at TASH? VI is an imcomplete applicaion. |
Integrate vi into builtin apps
tadziopazur
force-pushed
the
builtin_apps
branch
from
f72e503
to
f2f5cd6
Compare
|
Vi might be incomplete, but is useful for modifying short javascript files. |
sunghan-chang
approved these changes
Sep 8, 2017
rzr
reviewed
Nov 15, 2018
| @@ -125,8 +127,17 @@ install: | |||
|
|
|||
| endif | |||
|
|
|||
| ifeq ($CONFIG_BUILTIN_APPS)$(CONFIG_SYSTEM_I2CTOOL),yy) | |||
There was a problem hiding this comment.
mistake fixed in:
#2439 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tools come from apps/system.