Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expandable button: added implementation on Card and examples #1339

Conversation

TomaszLukawskiSam
Copy link
Contributor

@TomaszLukawskiSam TomaszLukawskiSam commented Jul 22, 2020

[Issue] #1336
[Problem] Expandable button: Card type - not implemented, no example
[Solution]

  • new example
  • extend styles for ui-content-area

[Screen]
image

@TomaszLukawskiSam TomaszLukawskiSam force-pushed the issue-1336-expandable-button-card branch from 7558be8 to f00540a Compare July 22, 2020 13:42
@TomaszLukawskiSam TomaszLukawskiSam marked this pull request as draft July 23, 2020 06:42
@TomaszLukawskiSam TomaszLukawskiSam force-pushed the issue-1336-expandable-button-card branch 10 times, most recently from 2996bb3 to 0656fc6 Compare July 27, 2020 14:47
@TomaszLukawskiSam TomaszLukawskiSam added 1.2 in review mobile Issue occured on mobile profile labels Jul 27, 2020
@TomaszLukawskiSam TomaszLukawskiSam marked this pull request as ready for review July 27, 2020 14:50
@@ -468,7 +468,7 @@
}

/**************************************
Slider
Slider
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be good to use 2 tabs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been changed by VSC :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this file are different indentation for comments. I think it doesn't matter.

@TomaszLukawskiSam TomaszLukawskiSam force-pushed the issue-1336-expandable-button-card branch from 0656fc6 to eb091f6 Compare July 28, 2020 08:50
[Issue] Samsung#1336
[Problem] Expandable button: Card type - not implemented, no example
[Solution]
 - new example
 - extend styles for ui-content-area

Signed-off-by: Tomasz Lukawski <t.lukawski@samsung.com>
Copy link
Collaborator

@korneliakobiela korneliakobiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@TomaszLukawskiSam TomaszLukawskiSam merged commit a833615 into Samsung:tau_1.2 Jul 29, 2020
@TomaszLukawskiSam TomaszLukawskiSam deleted the issue-1336-expandable-button-card branch July 29, 2020 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.2 in review mobile Issue occured on mobile profile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants