Skip to content

Commit

Permalink
(mobile) DropDownMenu: fix for wrong padding and wrong top margin
Browse files Browse the repository at this point in the history
[Issue] #1159
[Problem] More options list & Dropdown list -> shape
[Solution]
 - add missing padding to widget wrapper

Signed-off-by: Tomasz Lukawski <t.lukawski@samsung.com>
  • Loading branch information
TomaszLukawskiSam committed Jun 10, 2020
1 parent a74c56c commit 7c36a13
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 12 deletions.
14 changes: 4 additions & 10 deletions src/css/profile/mobile/common/dropdownmenu.less
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@dropdown-options-margin: 6 * @px_base;
@dropdown-options-margin: 3 * @px_base;

.ui-dropdownmenu-overlay {
opacity: 0;
Expand Down Expand Up @@ -182,6 +182,8 @@
z-index: 1201;
min-width: 168px;
max-width: 100vw;
padding: 3 * @px_base;

&.ui-dropdownmenu-options-vertical-margins {
margin-top: @dropdown-options-margin;
margin-bottom: @dropdown-options-margin;
Expand All @@ -190,15 +192,7 @@
visibility: visible;
overflow-y: auto;
}
&.ui-dropdownmenu-options-opened {
border-top: 1 * @px_base solid @color_dropdownmenu_list_group_stroke;
border-bottom: 1 * @px_base solid @color_dropdownmenu_list_group_stroke;
}
// top, bottom classes just describes direction in which menu is animated.
&.ui-dropdownmenu-options-top {
}
&.ui-dropdownmenu-options-bottom {
}

&.ui-dropdownmenu-options-opening.ui-dropdownmenu-options-top .ui-dropdownmenu-options {
.animation(open-to-top 300ms);
}
Expand Down
2 changes: 1 addition & 1 deletion src/css/profile/mobile/themes/dark.variables.less
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
@button-background-contained: @color-white;
@text-input-invalid-color: #ff6666;

@dropdown-menu-options-border: 3 * @px_base solid #525252;
@dropdown-menu-options-border: 0.75 * @px_base solid #525252;
@dropdown-menu-options-background: #3d3d3d;
@dropdown-menu-options-color: @color-white;

Expand Down
2 changes: 1 addition & 1 deletion src/css/profile/mobile/themes/light.variables.less
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@

@button-background-contained: @_black;
@text-input-invalid-color: #b00020;
@dropdown-menu-options-border: 1 * @px_base solid #cccccc;
@dropdown-menu-options-border: 0.25 * @px_base solid #cccccc;
@dropdown-menu-options-background: @popup-background-color;
@dropdown-menu-options-color: @_black;

Expand Down

0 comments on commit 7c36a13

Please sign in to comment.